fix: length validation for utf8 strings #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Current string length validation made with go's standard
len
function works incorrectly with non ascii characters. So if there any non-english symbols"maxLength"
validator will fail when it shouldn't.In this PR I'v replaced
len
withutf8.RuneCountInString
. Instead of number of bytes it will calculate number of runes.It will resolve most issues. But it don't take into account unicode text segmentation. So if there will be symbols such as emojis, that consists of more than one unicode character it still will calculate length incorrectly. More info could be found here.
So may be the next step is to add usage of https://github.com/rivo/uniseg. But considering it is a big change and new dependancy may be it is not worth it.