Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NewWithGroup accepting fiber.Router #361

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: NewWithGroup accepting fiber.Router #361

merged 1 commit into from
Apr 9, 2024

Conversation

barklan
Copy link
Contributor

@barklan barklan commented Apr 9, 2024 •
edited

Fixes #362

@barklan barklan mentioned this pull request Apr 9, 2024
Closed
danielgtaylor
danielgtaylor approved these changes Apr 9, 2024
View reviewed changes
Copy link
Owner

@danielgtaylor danielgtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry about that. Thanks for fixing 👍

@danielgtaylor danielgtaylor merged commit fcd6d9c into danielgtaylor:main Apr 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgtaylor danielgtaylor danielgtaylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fiber adapter NewWithGroup should accept fiber.Router interface
2 participants
@barklan @danielgtaylor