Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch reflect.StructOf panics in schema transformer #375

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

danielgtaylor
Copy link
Owner

@danielgtaylor danielgtaylor commented Apr 12, 2024

This catches a panic related to an unsupported feature of Go that you might run into with types from third-party libraries. The schema transformer prints a warning, skips the type for inserting links, and moves on. We cannot support this until the underlying language is updated, but at least it won't stop your service from running.

Fixes #371

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (911f3da) to head (d35a748).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   95.43%   92.51%   -2.93%     
==========================================
  Files          18       20       +2     
  Lines        2935     3513     +578     
==========================================
+ Hits         2801     3250     +449     
- Misses         97      224     +127     
- Partials       37       39       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielgtaylor danielgtaylor merged commit 864ecb4 into main Apr 12, 2024
4 of 5 checks passed
@danielgtaylor danielgtaylor deleted the fix-schema-transformer-panic branch April 12, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in OnAddOperation
1 participant