Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support netip.Addr as a special type #396

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

wolveix
Copy link
Contributor

@wolveix wolveix commented Apr 19, 2024

Hey! I realised after opening my issue on this (#395), that this should be a pretty trivial issue to resolve.

Please let me know if I've missed anything with this PR, and thanks again for all that you do!

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (e66ddf3) to head (c63b59e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          21       21           
  Lines        3516     3518    +2     
=======================================
+ Hits         3256     3258    +2     
  Misses        221      221           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@danielgtaylor danielgtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@danielgtaylor danielgtaylor merged commit 05a14f2 into danielgtaylor:main Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants