Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic on put without body #67

Merged
merged 1 commit into from
Sep 13, 2022
Merged

fix: panic on put without body #67

merged 1 commit into from
Sep 13, 2022

Conversation

danielgtaylor
Copy link
Owner

This adds an additional nil check to prevent a panic when registering or handling a request for a PUT operation without a request body. Also adds a test to exercise the functionality and confirm the auto-patch feature skips such operations.

@danielgtaylor danielgtaylor added the bug Something isn't working label Sep 13, 2022
@danielgtaylor danielgtaylor self-assigned this Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 87.15% // Head: 87.15% // No change to project coverage 👍

Coverage data is based on head (e1527a6) compared to base (518e34c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files          25       25           
  Lines        2133     2133           
=======================================
  Hits         1859     1859           
  Misses        193      193           
  Partials       81       81           
Impacted Files Coverage Δ
patch.go 85.82% <100.00%> (ø)
resolver.go 88.32% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@jmasonISP jmasonISP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@danielgtaylor danielgtaylor merged commit 78af577 into main Sep 13, 2022
@danielgtaylor danielgtaylor deleted the fix-put-no-body branch September 13, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants