Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Bug - No arguments are generated for stub methods when using import with proto definition #23

Closed
huan opened this issue Mar 9, 2020 · 1 comment · Fixed by #88 or #103
Closed

Import Bug - No arguments are generated for stub methods when using import with proto definition #23

huan opened this issue Mar 9, 2020 · 1 comment · Fixed by #88 or #103
Labels
bug Something isn't working has test Has a (xfail) test that verifies the bugfix or feature medium Medium effort issue, can fit in a single PR
Projects
Better Imports Betterproto
Milestone
Better Imports

Comments

@huan
Copy link

huan commented Mar 9, 2020

If I'm using the import in the proto file, like the following:

https://github.com/huan/python-betterproto-issue/blob/60d232c90c099abca4aea6dc1273121cd4f43d66/proto_with_import/puppet_service.proto#L1-L9

Then the betterproto will fail to generate the argument of the Ding method, like this:

https://github.com/huan/python-betterproto-issue/blob/60d232c90c099abca4aea6dc1273121cd4f43d66/gen_proto_with_import/puppet_grpc.py#L13

As we are expecting this:

https://github.com/huan/python-betterproto-issue/blob/60d232c90c099abca4aea6dc1273121cd4f43d66/gen_proto_without_import/puppet_grpc.py#L21

Reproduce Repo at https://github.com/huan/python-betterproto-issue
@huan huan mentioned this issue Mar 9, 2020
Closed
@huan huan changed the title Generate no arguments for stub methods when using import with proto defination No arguments are generated for stub methods when using import with proto defination Mar 9, 2020
@cetanu cetanu added the bug Something isn't working label May 21, 2020
@boukeversteegh boukeversteegh added this to Backlog in Betterproto May 25, 2020
@boukeversteegh boukeversteegh mentioned this issue May 25, 2020
Closed
@boukeversteegh
Copy link
Collaborator

Confirmed this bug and added a test-case f25c667

@boukeversteegh boukeversteegh added the has test Has a (xfail) test that verifies the bugfix or feature label May 25, 2020
@boukeversteegh boukeversteegh changed the title No arguments are generated for stub methods when using import with proto defination Import Bug - No arguments are generated for stub methods when using import with proto definition May 25, 2020
@boukeversteegh boukeversteegh added this to the Better Imports milestone May 25, 2020
@boukeversteegh boukeversteegh added this to To do in Better Imports May 25, 2020
@boukeversteegh boukeversteegh removed this from Backlog in Betterproto May 25, 2020
@boukeversteegh boukeversteegh added this to To do in Betterproto May 25, 2020
@boukeversteegh boukeversteegh added the medium Medium effort issue, can fit in a single PR label May 26, 2020
@boukeversteegh boukeversteegh mentioned this issue Jun 10, 2020
Merged
@boukeversteegh boukeversteegh linked a pull request Jun 10, 2020 that will close this issue
🍏 Fix imports #88
Merged
@boukeversteegh boukeversteegh moved this from To do to Review in progress in Betterproto Jun 11, 2020
Betterproto automation moved this from Review in progress to Done Jul 4, 2020
boukeversteegh added a commit to boukeversteegh/python-betterproto that referenced this issue Jul 5, 2020
@boukeversteegh
Fixes danielgtaylor#23 again, a broken test made it seem the issue wa…
3f519d4 
…s fixed before.
@boukeversteegh boukeversteegh mentioned this issue Jul 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working has test Has a (xfail) test that verifies the bugfix or feature medium Medium effort issue, can fit in a single PR
Projects
Betterproto
  
Done
Better Imports
  
To do
Milestone
Better Imports
3 participants
@boukeversteegh @huan @cetanu