Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.11.0 stop working #81

Closed
0fefe opened this issue Mar 21, 2022 · 3 comments
Closed

Version 0.11.0 stop working #81

0fefe opened this issue Mar 21, 2022 · 3 comments
Labels
bug Something isn't working question Further information is requested

Comments

@0fefe
Copy link

0fefe commented Mar 21, 2022

I upgraded to 0.11.0 version and now I get this error every time I want to run restish command

ERROR: Caught error: yaml: unmarshal errors:
line 1: cannot unmarshal !!seq into map[string]interface {}

@danielgtaylor danielgtaylor added the bug Something isn't working label Apr 3, 2022
@danielgtaylor
Copy link
Owner

@0fefe do you have an example command or response that is causing this so I can reproduce on my side? Did you upgrade from 0.10.0 to 0.11.0 or was it a prior version to that? Any other info to help me track this down?

@danielgtaylor
Copy link
Owner

I believe I'm able to reproduce the error with this small code example: https://go.dev/play/p/7_IME0SUEoz

The output (aka responses) which include that seem to work fine, however the command input from stdin seems to be able to produce that error because it assumes the input will be an object rather than possibly being an array. That happens at https://github.com/danielgtaylor/shorthand/blob/main/shorthand.go#L87-L97 but looking back at previous releases I see the old code at v0.10.0...v0.11.0#diff-a22a35e46a2a54e56098f46d313be424571104be770e9bf4b63a04f931719722L62-L65 had the same issue and should have also returned an error. Do you have an example that worked before but is not working now? I'm at a bit of a loss...

@danielgtaylor danielgtaylor added question Further information is requested needs-repro Needs an example to reproduce the problem and removed bug Something isn't working labels Apr 3, 2022
danielgtaylor added a commit that referenced this issue Apr 5, 2022
fix: sending non-structured-object input via stdin, fixes #81
@danielgtaylor danielgtaylor added bug Something isn't working and removed needs-repro Needs an example to reproduce the problem labels Apr 5, 2022
@danielgtaylor
Copy link
Owner

I believe I found the bug. Should be fixed in the next release. Thanks for reporting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants