Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS Config before Auth #129

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Add TLS Config before Auth #129

merged 1 commit into from
Nov 2, 2022

Conversation

MartyHub
Copy link
Contributor

Hello,

I'm trying to use Restish with a corporate API that requires OAuth 2.0 Client Credentials authentication.
The authentication /token endpoint also requires a client certificate.
With the current version of Restish, I've the following error message:

ERROR: Caught error: oauth2: cannot fetch token: 400 Bad Request
Response: <html>
<head><title>400 No required SSL certificate was sent</title></head>
...
</html>

With this proposed patch, it is working fine.
Can you please have a look and tell me if it can be merged?

Thanks and Regards

@danielgtaylor danielgtaylor self-assigned this Sep 12, 2022
@danielgtaylor danielgtaylor added the bug Something isn't working label Sep 12, 2022
danielgtaylor
danielgtaylor approved these changes Nov 2, 2022
View reviewed changes
Copy link
Owner

@danielgtaylor danielgtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks 👍

@danielgtaylor danielgtaylor merged commit 672c457 into danielgtaylor:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgtaylor danielgtaylor danielgtaylor approved these changes

Assignees

@danielgtaylor danielgtaylor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MartyHub @danielgtaylor