openapi: do not overflow the stack for circular types #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When JSON schema types reference each other, the example generation code blows up the stack. This patch adds a simple mechanism to avoid going more than (a completely arbitrarily chosen value of) 5 layers deep.
|
This bug is happening to me as well. I would really like this MR to be merged 👍 |
danielgtaylor
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JSON schema types reference each other, the example generation code blows up the stack. This patch adds a simple mechanism to avoid going more than (a completely arbitrarily chosen value of) 5 layers deep[1].
This patch correctly fixes the panic I was previously experiencing
[1]: it felt like anything more than 5 would make reading the example complex anyhow.