feat!: revamp default output behavior #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default redirected output to response body as JSON - Remove `--rsh-table` in favor of `-o table` - Reuse registered content types as output marshallers - Add a `PrettyMarshaller` which content types can (optionally) provide, e.g. JSON and Ion provide one now. - Readable output now colorizes matching braces/brackets - Differentiate between TTY and color within the code - When the filter `-f` option doesn't start with e.g. `body`, `headers`, or one of the valid other values it now returns an error rather than no output. Note: this is a breaking change in behavior.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 62.74% 66.22% +3.48%
==========================================
Files 22 22
Lines 2518 2594 +76
==========================================
+ Hits 1580 1718 +138
+ Misses 760 698 -62
Partials 178 178
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a number of small but related changes, the biggest being the breaking change in default output behavior when redirecting output to a file or pipe as it now just sends the response body as JSON when no filters are passed. List of all changes:
--rsh-tablein favor of-o tablePrettyMarshallerwhich content types can (optionally) provide, e.g. JSON and Ion provide one now.-foption doesn't start with e.g.body,headers, or one of the valid other values it now returns an error rather than no output.Note: this is a breaking change in behavior.