Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gron output with special chars #221

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: gron output with special chars #221

merged 1 commit into from
Oct 3, 2023

Conversation

danielgtaylor
Copy link
Owner

This simplifies the PathBuffer (and makes it a bit more inefficient) to generally lower complexity and ensure the correct output for fields containing ., ], or " characters in their name.

Fixes #217

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #221 (98245d9) into main (2c85909) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   76.94%   76.92%   -0.03%     
==========================================
  Files          26       26              
  Lines        3670     3666       -4     
==========================================
- Hits         2824     2820       -4     
  Misses        639      639              
  Partials      207      207              
Files Coverage Δ
cli/content.go 74.28% <100.00%> (ø)
cli/gron.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c85909...98245d9. Read the comment docs.

@danielgtaylor danielgtaylor merged commit 760fbd0 into main Oct 3, 2023
6 checks passed
@danielgtaylor danielgtaylor deleted the fix-gron branch October 3, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gron output fails on keys containing "."
1 participant