Fix: Could not extract the comment from MDF files due to replace string issue. #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To handle both cases "double quotes" and 'single quotes" in the namespace string.
|
Thank you Kevin! |
KevinRodrigues05
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
This is a small bug fix we realized when we could not extract the comment from the mdf file.
There seems to be an issue with the double and single quotes specified in the replace string.
The comment(variable) string seems to have single quotes in some of our mf4 files -
xmlns='http://www.asam.net/mdf/v4'.Hence I have provided a fix which will take care of both the cases (double & single quotes)
It is also tested on different mf4 files with my colleague Monica K. @kmonica92
Is this solution good enough if it works for you as well.