Use ruff for pyupgrade and isort #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -379,7 +378,7 @@ def from_dict(conversion: dict[str, Any]) -> v4b.ChannelConversion: | |||
| return conversion | |||
|
|
|||
|
|
|||
| def to_dict(conversion: ChannelConversionType) -> Union[dict, None]: | |||
| def to_dict(conversion: ChannelConversionType) -> dict | None: | |||
There was a problem hiding this comment.
Doesn't this require Python >= 3.10 ?
There was a problem hiding this comment.
Yes it does, but ruff ignores it, because the file contains from __future__ import annotations.
There was a problem hiding this comment.
Ok, let me know when it is ready for merging
There was a problem hiding this comment.
I'd say it's ready. This little change resulted in 73 modified files, that's enough for one PR 😄
danielhrisca
merged commit 17c7a8d
into
danielhrisca:development
17 of 18 checks passed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could activate many more rules to be checked on commit and in CI.