Activate Pylint Rules #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those comparison are to check is the value is not a number NaN |
Ah, i didn't know that. Would you mind if i replace it with np.isnan for readability? |
|
My concern is the execution speed in this case
|
zariiii9003
force-pushed
the
ruff_pylint
branch
from
6a97ec7
to
ae1f1a6
Compare
danielhrisca
requested changes
Jan 12, 2024
src/asammdf/blocks/mdf_v4.py
Outdated
| @@ -6593,7 +6590,7 @@ def get( | |||
| if name is None: | |||
| name = channel.name | |||
|
|
|||
| unit = conversion and conversion.unit or channel.unit | |||
| unit = conversion.unit if conversion else channel.unit | |||
There was a problem hiding this comment.
This is not right: if the conversion unit is empty then we need to check the channel unit as well
There was a problem hiding this comment.
True. I just found out, that the preview rule, which flagged this, will be removed soon
| @@ -174,7 +174,7 @@ def search_text_changed(self): | |||
| (group_index, channel_index): { | |||
| "names": [ch.name], | |||
| "comment": extract_xml_comment(ch.comment).strip(), | |||
| "unit": ch.conversion and ch.conversion.unit or ch.unit, | |||
| "unit": ch.conversion.unit if ch.conversion else ch.unit, | |||
There was a problem hiding this comment.
same as above, also applies to the following commit diffs
danielhrisca
approved these changes
Jan 16, 2024
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you check these?
asammdf/src/asammdf/gui/widgets/plot.py
Line 136 in 43852ff
asammdf/src/asammdf/gui/widgets/plot.py
Line 144 in 43852ff
asammdf/src/asammdf/gui/widgets/plot.py
Line 4460 in 43852ff
asammdf/src/asammdf/gui/widgets/plot.py
Line 4462 in 43852ff
asammdf/src/asammdf/gui/widgets/plot.py
Line 4503 in 43852ff
asammdf/src/asammdf/gui/widgets/plot.py
Line 4505 in 43852ff
asammdf/src/asammdf/gui/widgets/tabular_base.py
Line 1382 in 43852ff