Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn and relax global j1939 if non-extended IDs present #997

Merged
merged 16 commits into from
Apr 17, 2024

Conversation

hacklint
Copy link

I had a DBC file containing one message with non-extended ID.
asammdf refused to accept that and threw an exception even if the rest of the file was OK.
I think warning in this case may be a less drastic approach - the suggested change allows me
to run without modifying either asammdf locally or my incoming data, while still passing the tests.

Speaking of tests - it seems to me that running the GUI tests on a large screen (3840 x 2160)
places the gui window in the lower right part of the screen, but it seems the cursor is placed farther
and farther to "north-west", ie up and left - and after a while leaving the window which stops the
test sequence. Manually moving it back makes tests continue, but the behaviour is repeated,
Running on a "standard" sized screen does not seem to behave like this.

@danielhrisca danielhrisca merged commit 8101f14 into danielhrisca:development Apr 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants