new warning test

danieljbruce · Jan 26, 2023 · 37400a6 · 37400a6
1 parent c397608
commit 37400a6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/query.ts b/src/query.ts
@@ -213,6 +213,9 @@ class Query {
       this.filters.push(propertyOrFilter);
       return this;
     } else {
+      process.emitWarning(
+        'Providing Filter objects is recommended when using .filter'
+      );
       let operator = operatorOrValue as Operator;
       if (arguments.length === 2) {
         value = operatorOrValue as {};

diff --git a/test/query.ts b/test/query.ts
@@ -164,6 +164,17 @@ describe('Query', () => {
       assert.strictEqual(filter.op, '=');
       assert.strictEqual(filter.val, 'Stephen');
     });
+
+    it('should issue a warning when a Filter instance is not provided', done => {
+      new Query(['kind1']).filter('name', 'Stephen');
+      process.on('warning', warning => {
+        assert.strictEqual(
+          warning.message,
+          'Providing Filter objects is recommended when using .filter'
+        );
+        done();
+      });
+    });
   });
 
   describe('filter with Filter class', () => {