Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add zk circuits and contracts #3

Merged
merged 8 commits into from Sep 20, 2022
Merged

Feature/add zk circuits and contracts #3

merged 8 commits into from Sep 20, 2022

Conversation

rishotics
Copy link
Collaborator

  • Add ZK circuit for Hash Check using MiMc hash function and Merkle Tree Inclusion
  • Add smart contracts for OTP Validation and Social Recovery
  • Add test for both

danieljcss
danieljcss approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@danieljcss danieljcss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@danieljcss danieljcss merged commit 125beca into main Sep 20, 2022
3lLobo
3lLobo reviewed Sep 21, 2022
View reviewed changes
Copy link
Owner

@3lLobo 3lLobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should we gitignore the backend/circuits/HashCeck/build folder?

  • Same for backend/circuits/OTPVerification/build

  • Another one backend/typechain-types/

  • Set solidity to latest version?

backend/contracts/ZkOtpValidator.sol
lastValidatedTimestamp = input[1];
}

function verifyOTP(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishotics should we emit Events here to index with theGraph and notify the user/dapp?

backend/contracts/ZkSocialRecoveryWallet.sol
emit RecoveryExecuted(old, owner, recoveryRoundNumber);
}

function cancelRecovery(uint256 recoveryRoundNumber)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

backend/contracts/ZkValidator.sol
verifier = new Verifier();
}

function verifyProofForUserWallet(
Copy link
Owner

@3lLobo 3lLobo Sep 21, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3lLobo 3lLobo 3lLobo left review comments

@danieljcss danieljcss danieljcss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rishotics @danieljcss @3lLobo