Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecomparison #296

Open
wants to merge 36 commits into
base: kitp
Choose a base branch
from
Open

Codecomparison #296

wants to merge 36 commits into from

Conversation

eragusa
Copy link
Contributor

@eragusa eragusa commented May 18, 2022

Type of PR:
code for KITP code comparison
Description:

  • implemented sigma initialisation from flle
  • implemented initialisation of eccentric discs (from analytic prescription and from file)
  • added some interpolation routines for reading sigma and eccentricity from files
    Testing:
    tested against other codes in the code comparison

Enrico Ragusa and others added 30 commits June 9, 2021 16:21
eccentric setup positions working.
319c4cb
(set_disc) eccentric velocity setup working
dc9c34f
Fixed issue with dynamic allocation
8a651b4
Deactivated recentering of disc in CM for eccentric discs
5290262
Setup with flat eccentricity distr working
0595012
(set_disc) Implemented corrections for varying eccentricty profile an…
1259464 
…d constant flux along the streamline
Now always modifies velocity of COM while change its position only fo…
f8ba9ad 
…r e=0
Changed coordinate for ecc to lambda, removed azimuthal corrections.
96bbba5
Implementation with true anomaly and semimajor axis
57d66d8
set_disc implemented with Mmean, works with constant ecc gradient
d6c8a56
Eccentric setup with e(a) works from setup file. Extensive testing. T…
37d7f0e 
…ODO: implement reading profiles from file.
Added routines to load matrices from files and shape sigma and e(a).
00e34c6
Commtting transition to python 3 for sinkanalysis.py
ffcdc20
Included in the setup the integer variable eccprofile
c7edbb3
Added utils for loading files and interpolate grid.
cbd1012
Added module to store grid files
0cb3b32
All seems to compile without errors now, but seems incredibly slow!
68f8b89
For some reason compiler was stuck, but it works ok. Fixed a default …
4ae3468 
…value of eccprofile in setup
Removed a few print statements originally added for debugging
2feda73
Made final adjustments and made some tests to check non-eccentric set…
419e287 
…up was not broken.
Updated Makefile object lists as set_disc has a bunch of new dependen…
eee4f33 
…cies.
Corrected error in remove particles for moddump.
2260b29
Corrected dust initialisation for eccentric discs
f90ddaa
Added eccentric equation of state (ieos=20), i.e. locally isothermal …
2634ae2 
…(ieos=3) but using semi-major axis instead of radius
Modified calls to routine equationofstate() to accomodate ieos=20.
a6072e7
Added error statement if in load_from_file the file cannot be found.
755e97b
Fixed stupid mistake
436b1e5
Changed condition for centre of mass adjustment. Now it happens if e_…
8d71533 
…0 == 0 and eccprofile =! 4
CHanged setup_dust to properly setup the dust_to_gas variable in setu…
cb37abf 
…p file
Fixed some bugs in initialisation from sigma_grid
2bd658e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eragusa