GitHub actions workflow to check phantom+mcfost #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the failure here is due to #341 and needs to be fixed by pull request to MCFOST. Update: P-R opened at cpinte/mcfost#58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
continuous integration testing, closes #379
Description:
this is a GitHub action to compile phantom and link it against MCFOST, as needed for live phantom+mcfost simulations
the idea is to check if the API gets broken for whatever reason (could either be at the phantom or on the mcfost end).
Testing:
Will be tested in the actions workflow
Did you run the bots? no
Did you update relevant documentation in the docs directory? yes, the action follows recommended installation procedure for homebrew installation of mcfost in the mcfost help page