(build) fix a bunch of weird link failures with ifort on Mac OS #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Build failures fixed, closes #292 and #293
Description:
A bunch of phantom utilities fail to compile using ifort on Mac OS, with typical errors like:
this is a weird failure as these .o files are clearly present in the library being linked. It is ONLY an issue with ifort and ONLY on a Mac, possibly due to some conflict with the linker being used?
the workaround in any case is to add the relevant .o files explicitly in the object file list for the utilities being linked. This is rather ugly but better than the build failing. It also seems random which .o files need to be added
Testing (on an intel Mac):
Did you run the bots? no
Did you update relevant documentation in the docs directory? no