Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix #440

Merged
merged 14 commits into from
Jun 29, 2023
Merged

Bug Fix #440

merged 14 commits into from
Jun 29, 2023

Conversation

lsiess
Copy link
Contributor

@lsiess lsiess commented Jun 28, 2023

Type of PR:
Bug fix

Description:

  • Fix critical typo in set_star.f90
  • in set_star, ask to provide the sink luminosity
  • in checksetup, check that sink luminosity is defined if radiation pressure on dust is to be used.
  • Improve CE.rst
  • remane routine nucleation --> calc_nucleation to avoid conflict with a variable name

Testing:
OK

Did you run the bots? no but minor commit

Did you update relevant documentation in the docs directory? yes

@danieljprice
Copy link
Owner

failure here is in "make analysis" with SETUP=star, giving:

../src/utils/analysis_common_envelope.f90 This name has already been assigned a data type.   [RHOPART]
                                   omega_orb,kappai,kappat,kappar,pgas,mu,entropyi,rhopart,&                             

Copy link
Owner

@danieljprice danieljprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, thanks Lionel

@danieljprice danieljprice merged commit 15a1bea into danieljprice:master Jun 29, 2023
177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants