Chinese coin problem / bug fixes and tests added for sink particles in external potentials #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix
Description:
Fixed problems running the Chinese Coin problem from Chin & Chen (2005) as in the phantom paper. The main issue that if one sets mass1 not equal to 1 in the input file with the binary external force (iexternalforce=3) then this was not read from the input file. Also evaluation of the external force was accidentally turned off if there was only one sink particle in the simulation
Also added a few more things to the format bot (OPEN->open, CLOSE->close, TRIM->trim and a few other things)
Testing:
Now implemented in the test suite, can be run with
Did you run the bots? yes
Did you update relevant documentation in the docs directory? no