Mass transfer setup #561
Draft
Mass transfer setup #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljprice
approved these changes
Jun 27, 2024
| @@ -845,6 +845,15 @@ ifeq ($(SETUP), windtunnel) | |||
| ANALYSIS=analysis_common_envelope.f90 | |||
| endif | |||
|
|
|||
| ifeq ($(SETUP), masstransfer) | |||
| # Wind tunnel setup | |||
There was a problem hiding this comment.
please give a useful description as the comment here is propagated directly through to the documentation page: https://phantomsph.readthedocs.io/en/latest/user-guide/setups.html#all-setups
| @@ -1444,13 +1444,17 @@ subroutine write_options_eos(iunit) | |||
| endif | |||
|
|
|||
| select case(ieos) | |||
| case(2) | |||
There was a problem hiding this comment.
can use case(2,12) instead of separate case statements...
| !--------------------------------------------------------------------------! | ||
| module setup | ||
| ! | ||
| ! Setup of two stars or sink particles in a binary |
There was a problem hiding this comment.
please give a useful description here if possible (and reference to paper ideally even if it is in prep...)
|
build failures are because gamma is not read for a bunch of cases... seems to be caused by the changes to the case statement in read_options_eos ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.