Hide once a remote creature has been shown for the first time (#4)

daniellochner · Jul 4, 2023 · 2a8ce0f · 2a8ce0f
1 parent 7acedfa
commit 2a8ce0f
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 16 deletions.
diff --git a/...eatureCreator/Scripts/Runtime/Behaviours/Creature/Creature/NonPlayer/CreatureNonPlayer.cs b/...eatureCreator/Scripts/Runtime/Behaviours/Creature/Creature/NonPlayer/CreatureNonPlayer.cs
@@ -40,14 +40,8 @@ public override void Setup()
             base.Setup();
             Selectable.Setup();
 
-            if (!Loader.IsHidden)
-            {
-                Loader.ShowToMe();
-            }
-            else
-            {
-                Loader.OnHide();
-            }
+            Loader.OnShow += OnFirstTimeShown;
+            Loader.ShowToMe();
         }
 
         public override void OnDie(DamageReason reason, string inflicter)
@@ -81,6 +75,15 @@ public override void OnHide()
             Collider.enabled = false;
             Animator.enabled = false;
         }
+
+        private void OnFirstTimeShown()
+        {
+            if (Loader.IsHidden)
+            {
+                Loader.OnHide();
+            }
+            Loader.OnShow -= OnFirstTimeShown;
+        }
         #endregion
     }
 }
diff --git a/...eatureCreator/Scripts/Runtime/Behaviours/Creature/Creature/Player/CreaturePlayerRemote.cs b/...eatureCreator/Scripts/Runtime/Behaviours/Creature/Creature/Player/CreaturePlayerRemote.cs
@@ -39,14 +39,8 @@ public override void Setup()
             Selectable.Setup();
             Namer.Setup();
 
-            if (!Loader.IsHidden)
-            {
-                Loader.ShowToMe();
-            }
-            else
-            {
-                Loader.OnHide();
-            }
+            Loader.OnShow += OnFirstTimeShown;
+            Loader.ShowToMe();
         }
 
         public override void OnDie(DamageReason reason, string inflicter)
@@ -84,6 +78,15 @@ public override void OnHide()
 
             Namer.enabled = false;
         }
+
+        private void OnFirstTimeShown()
+        {
+            if (Loader.IsHidden)
+            {
+                Loader.OnHide();
+            }
+            Loader.OnShow -= OnFirstTimeShown;
+        }
         #endregion
     }
 }