Fix calling nodeInformer in EgressIPManager.

This commit adds nodeInformer to the creation of a eim, as previously it
couldn't be instatiated. In addition, it triggers the change of EIP on
the hostsubnet when the node can't be reached.

pkg/network/master/egressip.go

@@ -49,9 +49,10 @@ func newEgressIPManager() *egressIPManager {
 	return eim
 }
 
-func (eim *egressIPManager) Start(networkClient networkclient.Interface, hostSubnetInformer networkinformers.HostSubnetInformer, netNamespaceInformer networkinformers.NetNamespaceInformer) {
+func (eim *egressIPManager) Start(networkClient networkclient.Interface, hostSubnetInformer networkinformers.HostSubnetInformer, netNamespaceInformer networkinformers.NetNamespaceInformer, nodeInformer kcoreinformers.NodeInformer) {
 	eim.networkClient = networkClient
 	eim.hostSubnetInformer = hostSubnetInformer
+	eim.nodeInformer = nodeInformer
 	eim.tracker.Start(hostSubnetInformer, netNamespaceInformer)
 }
 
@@ -163,6 +164,16 @@ func (eim *egressIPManager) poll(stop chan struct{}) {
 	}
 }
 
+func isNodeConditionGood(cond v1.NodeCondition) bool {
+	isNodeGood := true
+	if cond.Type == v1.NodeReady {
+		if cond.Status == v1.ConditionFalse || cond.Status == v1.ConditionUnknown {
+			isNodeGood = false
+		}
+	}
+	return isNodeGood
+}
+
 func (eim *egressIPManager) check(retrying bool) (bool, error) {
 	var timeout time.Duration
 	if retrying {
@@ -183,12 +194,12 @@ func (eim *egressIPManager) check(retrying bool) (bool, error) {
 		}
 
 		for _, cond := range nn.Status.Conditions {
-			if cond.Type == v1.TaintNodeNotReady {
-				klog.Warningf("Node %s is not Ready", node.ip)
+			if !isNodeConditionGood(cond) {
+				klog.Warningf("Node %s is not Ready", node.name)
 				node.offline = true
 				eim.tracker.SetNodeOffline(node.ip, true)
 				// Return when there's a not Ready node
-				return true, nil
+				return false, nil
 			}
 		}
 

pkg/network/master/master.go

@@ -115,7 +115,7 @@ func (master *OsdnMaster) startSubSystems(pluginName string) {
 	}
 
 	eim := newEgressIPManager()
-	eim.Start(master.networkClient, master.hostSubnetInformer, master.netNamespaceInformer)
+	eim.Start(master.networkClient, master.hostSubnetInformer, master.netNamespaceInformer, master.nodeInformer)
 }
 
 func (master *OsdnMaster) checkClusterNetworkAgainstLocalNetworks() error {