Improved handling of non-ASCII characters in transcript printing and JSON output from yt command
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JSON output - Updated print(transcript) to handle non-ASCII characters correctly. - Modified print statements to use ensure_ascii=False in json.dumps for correct display of non-ASCII characters. - Implemented exception handling to manage potential UnicodeEncodeErrors, ensuring fallback encoding to avoid garbled text. This change enhances the readability of outputs containing non-ASCII characters and addresses potential encoding issues across different environments.
|
We're getting ready to migrate to Golang; please resubmit then if this hasn't been addressed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Improved handling of non-ASCII characters in transcript printing and JSON output from
ytcommandThis change enhances the readability of outputs containing non-ASCII characters and addresses potential encoding issues across different environments.
Related issues and Screenshots
See this issue: JFK#1