Hack vpc_osx to not split with ',' in $PreprocessorDefinitions #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: - This finally fixes that stupid issue with TF2C_AUTHDATA_KEY and TF2C_AUTHDATA_XOR preprocessor definitions in server_tf2classic.vpc - If updated VPC binaries are ever pulled from Valve, this hack will need to be re-done Instructions on how to re-do this hack in the future if necessary: 1. Open vpc_osx in a disassembler 2. Go to function CSolutionGenerator_Xcode::EmitBuildSettings 3. Find the call to the CSplitString::CSplitString constructor just before the call to CVPC::GetMacrosMarkedForCompilerDefines (there are several calls to the CSplitString constructor in the function, and you just want this particular one) 4. One of the arguments to that call is the immediate value 2; overwrite it with 1 BEFORE: C7 44 24 0C 02 00 00 00 mov dword ptr [esp+0Ch], 2 E8 5C 93 03 00 call CSplitString::CSplitString AFTER: C7 44 24 0C 01 00 00 00 mov dword ptr [esp+0Ch], 1 E8 5C 93 03 00 call CSplitString::CSplitString
|
I'd also suggest reverting fbfceeb now, if you want. Spaces were never the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
TF2C_AUTHDATA_KEYandTF2C_AUTHDATA_XORpreprocessor definitions inserver_tf2classic.vpcInstructions on how to re-do this hack in the future if necessary:
vpc_osxin a disassemblerCSolutionGenerator_Xcode::EmitBuildSettingsCVPC::GetMacrosMarkedForCompilerDefines(there are several calls to theCSplitStringconstructor in the function, and you just want this particular one)BEFORE:
AFTER: