Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #9

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Fix warnings #9

merged 2 commits into from
Feb 12, 2020

Conversation

danielmoncada
Copy link
Owner

The following moment warning appeared for a user:

WARNING in Entry point '@danielmoncada/angular-datetime-picker' contains deep imports into 'C:/Users/jcomp/git/servoy_ngclient2/servoyeclipse/com.servoy.eclipse.ngclient.ui/node/node_modules/moment/moment'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

  • Update to not provide a deep import. used '/moment' instead of '/moment/moment'

@danielmoncada danielmoncada merged commit 3cd90a0 into master Feb 12, 2020
@danielmoncada danielmoncada deleted the FixWarnings branch February 12, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant