Skip to content
This repository has been archived by the owner on Nov 23, 2018. It is now read-only.

Simplified documentation for next warts remover version. #23

Closed
wants to merge 1 commit into from
Closed

Simplified documentation for next warts remover version. #23

wants to merge 1 commit into from

Conversation

Jentsch
Copy link

@Jentsch Jentsch commented Jul 10, 2016

Hi as soon as the change of wartremover/wartremover#245 is published the documentation could be simplified. This was the initial reason behind that pull request.

May, but not sure how, this could be predefined in ScalaWarts.scala? But I'm not sure how to detect that the Routes plugin is enabled or not.

@Jentsch
Copy link
Author

Jentsch commented Jul 10, 2016

And I'm also not sure how to handle such (may be) long pending pull request. Sry

@danielnixon
Copy link
Owner

Thanks! Will sit on this until the next version of wartremover.

@Jentsch
Copy link
Author

Jentsch commented Jul 21, 2016

Thanks for doing so.
What about the idea to make this the default configuration?

@danielnixon
Copy link
Owner

Done in 04c3d62bbbe6d5b844f487bfa0f3e610b7431fac. I'll replace that with routes.in(Compile).value when wartremover is updated.

@Jentsch
Copy link
Author

Jentsch commented Jul 24, 2016

Nice! I wonder, if somebody disables the routes plugin in his/her project, would routes.in(Compile).value enable it again? And if so, how could this be prevented?

@danielnixon
Copy link
Owner

Good questions. I'm no sbt expert. I'll investigate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants