Dockerfile and scripts for development #119
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I wanted to see if I can work on tiddlypouch locally, so I set up a docker container with all the software needed for building and running it. I assume you are not using Docker for working on tiddlypouch, and that's totally fine with me.
The changes in this PR could make it easier for people to contribute in the future, even if they don't use Docker, because by looking at the Dockerfile they learn to some degree what they need to install (*). For contributers willing to work with Docker, this should make things significantly simpler. In general, using Docker in this way helps keep the host system clean from a particular project's requirements (with the exception of Docker, of course), which is really helpful when projects require conflicting versions of, say, nodejs.
(*) because I was lazy and installed a "meta package", this is not as detailed as it could be
There's a few things that aren't solved so far:
Before putting any more work into this, I would kindly ask if this setup, after being brought into a good shape, is a welcome contribution to the project.
One obvious risk of adding this is the added maintainence burden, in particular if the core developers do not use Docker.