Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportGenerator does not have strong name. #210

Closed
acesiddhu opened this issue Feb 13, 2019 · 4 comments
Closed

ReportGenerator does not have strong name. #210

acesiddhu opened this issue Feb 13, 2019 · 4 comments

Comments

@acesiddhu
Copy link
Contributor

Is there a reason why Reportgenerator dlls are not strongly named. can we make them strongly named?

@danielpalme
Copy link
Owner

What would be the advantage?

@acesiddhu
Copy link
Contributor Author

I was trying to use report generator in our build system which has a restriction to consume only strongly named dlls. Hence the ask.

@danielpalme
Copy link
Owner

ok, but that would mean that all dependencies have to be signed as well.
That's currently not the case: See SixLabors/ImageSharp#738

@danielpalme
Copy link
Owner

I was finally able to sign the ReportGenerator DLLs with a strong name.

Release 4.6.0 contains the changes:
https://www.nuget.org/packages/ReportGenerator/4.6.0
https://www.nuget.org/packages/dotnet-reportgenerator-globaltool/4.6.0
https://www.nuget.org/packages/ReportGenerator.Core/4.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants