Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: How about a Html_Dark output option? #433

Closed
fgimian opened this issue Jun 19, 2021 · 17 comments
Closed

Suggestion: How about a Html_Dark output option? #433

fgimian opened this issue Jun 19, 2021 · 17 comments

Comments

@fgimian
Copy link

fgimian commented Jun 19, 2021

Hey there, really love this extension, thanks so much!

I was wondering if you would consider also adding a beautiful dark themed version of the standard Html output for those of us who are used to viewing code in darker environments 😄

Thanks heaps
Fotis

@danielpalme
Copy link
Owner

Have you tried -repottypes:HtmlInline_AzurePipelines_Dark as a command line argument?

@fgimian
Copy link
Author

fgimian commented Jun 19, 2021

Have you tried -repottypes:HtmlInline_AzurePipelines_Dark as a command line argument?

Thanks heaps for the reply, yep I have. It did feel quite minimal and not quite as pretty as I had hoped to be completely honest.

I find the default Html report to be more nicely formatted for regular display and was just thinking that maybe we could have a nice dark version of that.

What do you think?

But happy to use the Azure template for now anyway 😄

Huge thanks!
Fotis

@fgimian
Copy link
Author

fgimian commented Jun 19, 2021

Perhaps I can provide a little more info.

  • Consider a less dramatic contrast for the table borders, something much more subtle
  • Consider a dark grey instead of dark black for the background
  • Consider putting priority on a nicer font for the code, like Consolas on Windows and Merlo on macOS (IIRC)

I'll try to do a mock up of some minor refinements for your consideration 😄

@fgimian
Copy link
Author

fgimian commented Jun 19, 2021

This is just a little mock up of my ideas:

Before

image

After

image

Some points to think about:

  • I find a completely black background colour to be harsh so I've gone for background-color: #333;
  • The default monospace font on Windows is pretty ugly (Courier New) so I put a preference on Consolas which is available on all Windows systems, with a fallback to the usual monospace font code { font-family: Consolas, monospace; }
  • I made the borders around the overview table much more gentle border: solid 1px #444;
  • Changed the background colour of h1 to stand out with the new shades h1 { background-color: #555453; color: #fff; }

Of course, there would probably be a few more little tweaks like this.

The default Html layout also has nicer left and right margins I think for general reading, but this is a minor thing.

Kindest regards
Fotis

@danielpalme
Copy link
Owner

Thanks for your detailed suggestions. I will add this in the next release!

@danielpalme
Copy link
Owner

I added some new report types (HtmlDark, HtmlSummaryDark, HtmlInlineDark).
Perhaps you want to have a look at the new sample reports before I publish a new release.

I also made some changes to the existing HtmlInline_AzurePipelines_Dark report.
HtmlDark.zip
HtmlInline_AzurePipelines_Dark.zip

@fgimian
Copy link
Author

fgimian commented Jun 21, 2021

I added some new report types (HtmlDark, HtmlSummaryDark, HtmlInlineDark).
Perhaps you want to have a look at the new sample reports before I publish a new release.

I also made some changes to the existing HtmlInline_AzurePipelines_Dark report.
HtmlDark.zip
HtmlInline_AzurePipelines_Dark.zip

Thank you so much, I'll check them out ASAP and get back to you.

@fgimian
Copy link
Author

fgimian commented Jun 21, 2021

WOW! That looks absolutely incredible! Thank you so so much for your hard work on this 😄

Just a few additional very minor suggestions if I may:

Font Size in Filter

The font size inside the right text Filter text box really is a bit too small I think, I would suggest simply removing the font-size: 0.8em; in the .customizebox div.right input class to bring the text back to the regular size there.

Input / Select Box Border Colour

I think that both the text and select box have quite a bright border (seemingly white). Changing this for the text box is easy:

.customizebox div.right input { width: 150px; border-color: #888; }

However, I think styling the select will involve a div outside the box, similar to https://codepen.io/ericrasch/pen/zjDBx

Table Heading Row Background Colour

Also maybe consider using a different colour for the th in the table

.overview thead th { background-color: #444 }

image

Sort Arrow Colours

And just one more final thing, the arrows when sorting seem to be black on the dark theme. Can we make them a brighter colour like grey or similar?

image

Thanks again for everything!
Fotis

@danielpalme
Copy link
Owner

Thanks for your feedback. I don't understand the last point "Sort Arrow Colours".
For me they are grey and the active column is red. Your screenshot also shows a red arrow.

danielpalme added a commit that referenced this issue Jun 21, 2021
@danielpalme
Copy link
Owner

Here's my latest version of the report:
Html_LightAndDark.zip

I decided not to add a bunch of new report types. Instead all the different HTML reports now adapt the currently active Windows/macOS/Linux or Browser theme. So everyone get's his preferred version without having to generate a different report.
To test both versions, just toggle light/dark mode in your OS.

@fgimian
Copy link
Author

fgimian commented Jun 22, 2021

Thanks for your feedback. I don't understand the last point "Sort Arrow Colours".
For me they are grey and the active column is red. Your screenshot also shows a red arrow.

I'm sincerely sorry, I'm colourblind and just assumed that was black. Red and black look virtually identical to me. 😄

Here's my latest version of the report:
Html_LightAndDark.zip

I decided not to add a bunch of new report types. Instead all the different HTML reports now adapt the currently active Windows/macOS/Linux or Browser theme. So everyone get's his preferred version without having to generate a different report.
To test both versions, just toggle light/dark mode in your OS.

Looks beautiful to me! Thank you so so much for being so receptive to ideas.

Cheers!
Fotis

@danielpalme
Copy link
Owner

Thanks for your detailed suggestions.
New release 4.8.11 contains the new dark mode!

@fgimian
Copy link
Author

fgimian commented Jun 22, 2021

Thanks for your detailed suggestions.
New release 4.8.11 contains the new dark mode!

Thanks so much, I’ll try it out today! 😊

@silkfire
Copy link

silkfire commented Feb 8, 2022

@danielpalme Is there any way to force a light theme? I'm using a dark theme in the OS but would like my reports to be light.

@danielpalme
Copy link
Owner

@silkfire:
I'm currently working on a new release (v 5.1).
I will add the following report types in this release:

  • Html: Will use the OS/browser theme
  • Html_Light: Will use the light theme
  • Html_Dark: Will use the dark theme

But you'll have to be a litte patient, since the new release is not finished yet.

@danielpalme danielpalme reopened this Feb 9, 2022
@silkfire
Copy link

silkfire commented Feb 9, 2022

I'm okay with that, there's no rush, really. I appreciate having options. Thank you.

@danielpalme
Copy link
Owner

The new report types are now available with release 5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants