feat: Simulate location for iOS17 #403

kvs-coder · 2024-04-25T14:17:22Z

Why?

The current setlocation only works for iOS below 17, the iOS 17 introduces a new instrumentation service com.apple.instruments.dtservicehub with the channel id com.apple.instruments.server.services.LocationSimulation for the simulated location.

How?

By using DTX make a channel call:

imulateLocationWithLatitude:longitude: with args to start the location simulation
stopLocationSimulation to stop and clear the location simulation & data
The response payloads for both methods are <nil>

kvs-coder · 2024-04-25T14:36:18Z

ios/instruments/helper.go

+			dtxConn, err = dtx.NewTunnelConnection(device, serviceNameiOS17)
+			if err != nil {
+				return nil, err
+			}


TBH looks not great with iOS 17 as a fallback, probably a proper check for iOS version would avoid potentially unlimited nesting :)

Maybe can be done as a separate refactoring PR

actuall this part is solved already in #396 but unfortunately it's not merged yet, and I can't rebase someone else's PR. Maybe pinging @michal-przytarski works and he can rebase, after that I can merge it.

panderman · 2024-04-28T01:40:24Z

main.go

@@ -232,6 +233,7 @@ The commands work as following:
   ios setlocation [options] [--lat=<lat>] [--lon=<lon>]              Updates the location of the device to the provided by latitude and longitude coordinates. Example: setlocation --lat=40.730610 --lon=-73.935242
   ios setlocationgpx [options] [--gpxfilepath=<gpxfilepath>]         Updates the location of the device based on the data in a GPX file. Example: setlocationgpx --gpxfilepath=/home/username/location.gpx
   ios resetlocation [options]                                        Resets the location of the device to the actual one
+   ios simulatelocation [options] [--lat=<lat>] [--lon=<lon>]	      iOS 17 way to set location of the device to the provided by latitude and longitude coordinates. Example: simulatelocation --lat=55.75582600 --lon=37.61729990 --address=fd19:a731:684f::1 --rsd-port=61935


Is there a method automatically get address and rsd-port values?

If you are using go-ios with go-ios tunnel start that's happening implicitly (and you can view the address and port of the managed tunnels with go-ios tunnel ls)

If you are using go-ios with go-ios tunnel start that's happening implicitly (and you can view the address and port of the managed tunnels with go-ios tunnel ls)

thanks

If you are using go-ios with go-ios tunnel start that's happening implicitly (and you can view the address and port of the managed tunnels with go-ios tunnel ls)

By the way, i'm using mac now, does it work with windows?

dmissmann · 2024-04-29T07:33:57Z

main.go

@@ -122,6 +122,7 @@ Usage:
  ios setlocation [options] [--lat=<lat>] [--lon=<lon>]
  ios setlocationgpx [options] [--gpxfilepath=<gpxfilepath>]
  ios resetlocation [options]
+  ios simulatelocation [options] [--lat=<lat>] [--lon=<lon>]


there are already these three commands to handle location simulation, lets re-use them

ios setlocation [options] [--lat=<lat>] [--lon=<lon>] ios setlocationgpx [options] [--gpxfilepath=<gpxfilepath>] ios resetlocation [options]

dmissmann · 2024-04-29T07:42:21Z

ios/instruments/helper.go

+			dtxConn, err = dtx.NewTunnelConnection(device, serviceNameiOS17)
+			if err != nil {
+				return nil, err
+			}


actuall this part is solved already in #396 but unfortunately it's not merged yet, and I can't rebase someone else's PR. Maybe pinging @michal-przytarski works and he can rebase, after that I can merge it.

dmissmann · 2024-04-29T07:44:28Z

ios/instruments/location_simulation.go

+}
+
+// Start sets geolocation with provided params
+func (d *LocationSimulationService) Start(lat string, lon string) error {


I would be a bit more verbose in the method name, Start/Stop are very generic. StartSimulateLocation and StopSimulateLocation are better understandable IMO.

dmissmann · 2024-04-29T07:45:29Z

main.go

@@ -232,6 +233,7 @@ The commands work as following:
   ios setlocation [options] [--lat=<lat>] [--lon=<lon>]              Updates the location of the device to the provided by latitude and longitude coordinates. Example: setlocation --lat=40.730610 --lon=-73.935242
   ios setlocationgpx [options] [--gpxfilepath=<gpxfilepath>]         Updates the location of the device based on the data in a GPX file. Example: setlocationgpx --gpxfilepath=/home/username/location.gpx
   ios resetlocation [options]                                        Resets the location of the device to the actual one
+   ios simulatelocation [options] [--lat=<lat>] [--lon=<lon>]	      iOS 17 way to set location of the device to the provided by latitude and longitude coordinates. Example: simulatelocation --lat=55.75582600 --lon=37.61729990 --address=fd19:a731:684f::1 --rsd-port=61935


If you are using go-ios with go-ios tunnel start that's happening implicitly (and you can view the address and port of the managed tunnels with go-ios tunnel ls)

dmissmann · 2024-04-30T07:40:39Z

ios/instruments/location_simulation.go

+}
+
+// StartSimulateLocation sets geolocation with provided params
+func (d *LocationSimulationService) StartSimulateLocation(lat string, lon string) error {


sorry I missed that before. This method should already receive numbers and not strings

Suggested change

func (d *LocationSimulationService) StartSimulateLocation(lat string, lon string) error {

func (d *LocationSimulationService) StartSimulateLocation(lat, lon float64) error {

dmissmann · 2024-04-30T07:55:21Z

main.go

+	latitude, err := strconv.ParseFloat(lat, 64)
+	if err != nil {
+		exitIfError("location simulation failed to parse lat", err)
+	}
+
+	longitude, err := strconv.ParseFloat(lon, 64)
+	if err != nil {
+		exitIfError("location simulation failed to parse lon", err)
+	}


the if check happens in exitIfError already

Suggested change

latitude, err := strconv.ParseFloat(lat, 64)

if err != nil {

exitIfError("location simulation failed to parse lat", err)

}

longitude, err := strconv.ParseFloat(lon, 64)

if err != nil {

exitIfError("location simulation failed to parse lon", err)

}

latitude, err := strconv.ParseFloat(lat, 64)

exitIfError("location simulation failed to parse lat", err)

longitude, err := strconv.ParseFloat(lon, 64)

exitIfError("location simulation failed to parse lon", err)

The current setlocation only works for iOS below 17, the iOS 17 introduces a new instrumentation service com.apple.instruments.dtservicehub with the channel id com.apple.instruments.server.services.LocationSimulation for the simulated location. Co-authored-by: fish-sauce <victor.kachalov@saucelabs.com>

This reverts commit 2024bf1.

kvs-coder changed the title ~~Simulate location for iOS17~~ feat: Simulate location for iOS17 Apr 25, 2024

kvs-coder commented Apr 25, 2024

View reviewed changes

panderman reviewed Apr 28, 2024

View reviewed changes

dmissmann requested changes Apr 29, 2024

View reviewed changes

dmissmann requested changes Apr 30, 2024

View reviewed changes

dmissmann reviewed Apr 30, 2024

View reviewed changes

fish-sauce force-pushed the simulate-location branch 2 times, most recently from 65bd522 to 4bc12cc Compare April 30, 2024 08:58

dmissmann approved these changes Apr 30, 2024

View reviewed changes

Add location simulation for iOS 17 devices

8474f7f

fish-sauce force-pushed the simulate-location branch from 4bc12cc to 8474f7f Compare April 30, 2024 10:16

htlou mentioned this pull request May 1, 2024

[Feature] iOS 17 support Schlaubischlump/LocationSimulator#171

Open

dmissmann merged commit fe5e60b into danielpaulus:main May 2, 2024
2 checks passed

michal-przytarski added a commit to bitbar/go-ios that referenced this pull request May 6, 2024

Revert "feat: Simulate location for iOS17 (danielpaulus#403)"

52ea419

This reverts commit 2024bf1.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Simulate location for iOS17 #403

feat: Simulate location for iOS17 #403

kvs-coder commented Apr 25, 2024

kvs-coder Apr 25, 2024 •

edited

Loading

dmissmann Apr 29, 2024

panderman Apr 28, 2024

dmissmann Apr 29, 2024

panderman Apr 30, 2024

panderman Apr 30, 2024

dmissmann Apr 29, 2024

dmissmann Apr 29, 2024

dmissmann Apr 29, 2024

dmissmann Apr 29, 2024

dmissmann Apr 30, 2024

dmissmann Apr 30, 2024

	func (d *LocationSimulationService) StartSimulateLocation(lat string, lon string) error {
	func (d *LocationSimulationService) StartSimulateLocation(lat, lon float64) error {

feat: Simulate location for iOS17 #403

feat: Simulate location for iOS17 #403

Conversation

kvs-coder commented Apr 25, 2024

Why?

How?

kvs-coder Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kvs-coder Apr 25, 2024 •

edited

Loading