Upgrade to Angular 9 and animejs 3 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also: - upgrade all others deps to latest versions - fixes unit and e2e tests that were broken for a while - delete obsolete backup files - disable Ivy because libs cannot be published as Ivy for now - always use `npm` via `ng` commands
|
This is the proper, final version of Angular 9 migration PR. |
|
The last commit adds Github Actions integration to run the tests and linting. You can see it is passing there: https://github.com/Ecodev/angular-particle-effect-button/actions/runs/47145011 |
To support Angular Universal we must not access `document` directly, but since actually all browser support the non-prefixed `transform` CSS key, then we don't need document at all. Simplifying our code and bringing Angular Universal support at the same time. See https://developer.mozilla.org/en-US/docs/Web/CSS/transform#Browser_compatibility
|
You did a great job here! |
|
Thanks for merging and releasing promptly. For the next version, I would suggest to release it as 1.0.0 to better communicate the fact that this package is 2 years, maintained and production ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also:
npmviangcommands