0.2.9 #98
Merged
0.2.9 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this get built into the docker image(s)https://hub.docker.com/r/causticlab/hass-configurator-docker/? |
|
This isn't built by you, sorry. Will take it up with CausticLab |
|
There's already an open PR for that: CausticLab/hass-configurator-docker#5 |
|
Sorry that it took that long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes coming up. I'll update this post accordingly.
Changelog:
The change regarding the icons and the HASS-help is caused by the issues #85 and #34. Embedding those external sites makes JavaScript blockers throw alerts and may cause the configurator to have issues in case it is used in an environment that's not connected to the internet. Besides that loading the content of those sites generates traffic that can be saved and increases the time it takes to load the configurator. Compared to the actual configuring, the time spent on those two sites doesn't justify the created overhead.
Opening files by URL was requested with issue #95 . The way this is used is by appending
/?loadfile=/path/to/fileto the base URL of the configurator. So for examplehttps://192.168.1.123:3218/?loadfile=/home/homeassistant/.homeassistant/configuration.yamlThe
ENFORCE_BASEPATHwas requested in Issue #68 . IfBASEPATHis set andENFORCE_BASEPATHset toTrue, then it's not possible to browse outsite of the basepath or open files outside. Downloading is blocked as well. Did I miss anything?Also included: Issue #99 (search-function for entities)