Rebased fork1 (#213) #228
Closed
Rebased fork1 (#213) #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge changes from PR 147.
|
👍 |
|
Are there a plan/timeline for merging this? |
|
There are a lot of changes in this MR (some completely unrelated to performances), so I guess it's really hard for @danielqsj to do a review :/ Also, why are you opening this MR while #213 is still opened ? Can't you rebase ? Thanks for your work btw :) |
|
@alesj @brunsgaard there is another PR #238 which looks like based on this PR and do more enhancement. We should compare and make these two PRs together. |
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #213 and added minor things for easy Travis release.