19364 - Fix calculation of the hint's position. The problem was that the.... #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... orientationDidChangeNotification was called before the views did finish layout correctly. In landscape mode, the position was calculated based on the portrait mode bounds of the superview and vice versa
|
Thank you @FannyHogberg 🤩 I’ll take a look when I’m back from my trip. |
|
I realized this fix didnt work inside the Bookbeat app, only in your test demo project. I will create a new PR with the new fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... orientationDidChangeNotification was called before the views did finish layout correctly. In landscape mode, the position was calculated based on the portrait mode bounds of the superview and vice versa