Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibilityText to standard and deferredHint #7

Merged

Conversation

sebbo176
Copy link
Contributor

This PR adds a accessibilityText to hints. It is defaulted to nil so apps using this will not have to change anything and they will still work as they did before.

But if you set the accessibilityText the hint will get focus in voiceOver and it will read the text set in accessibilityText.

@danielsaidi
Copy link
Owner

Neat! Could I just ask you to adjust the code in TuttiExample/ViewController+Hints.swift so that it uses text for both text and accessibilityText in both hints? Or to remove the text variables and just use strings in the initializers?

@sebbo176 sebbo176 force-pushed the accessibilitytext_for_hints branch from 3ee4bcf to 9a488a5 Compare April 1, 2019 07:20
@sebbo176
Copy link
Contributor Author

sebbo176 commented Apr 1, 2019

Good idea! I Implemented accessibilityText for both hints in a force push of the same commit.

@danielsaidi danielsaidi merged commit 9c17369 into danielsaidi:master Apr 1, 2019
@danielsaidi danielsaidi added this to the 2.0 milestone Apr 1, 2019
@danielsaidi
Copy link
Owner

Thank you! I'll release this as 2.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants