Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create placeholders #220

Merged
merged 11 commits into from Oct 9, 2022
Merged

Create placeholders #220

merged 11 commits into from Oct 9, 2022

Conversation

eduardconstantin
Copy link
Contributor

@eduardconstantin eduardconstantin commented Oct 8, 2022 •
edited by danielschuster-muc

Pull Request Type

  • Other

Summary

  • Create wizard placeholder to be used in characters page

@vercel
Copy link

vercel bot commented Oct 8, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
potter-db ✅ Ready (Inspect) Visit Preview Oct 9, 2022 at 9:01AM (UTC)

@eduardconstantin eduardconstantin marked this pull request as draft October 8, 2022 09:01
@vercel vercel bot temporarily deployed to Preview October 8, 2022 09:03 Inactive
@eduardconstantin eduardconstantin mentioned this pull request Oct 8, 2022
Closed
@danielschuster-muc danielschuster-muc linked an issue Oct 8, 2022 that may be closed by this pull request
[Feature Request]: Create new placeholder svg images #216
Closed
@vercel vercel bot temporarily deployed to Preview October 8, 2022 15:57 Inactive
@eduardconstantin eduardconstantin marked this pull request as ready for review October 8, 2022 15:58
danielschuster-muc
danielschuster-muc requested changes Oct 8, 2022
View reviewed changes
Copy link
Owner

@danielschuster-muc danielschuster-muc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those images are just awesome! Good job!

Can you just pull from origin/master, so that you can also implement the image for the spells.
And could you rename the images to missing_type?

@eduardconstantin
Copy link
Contributor Author

Thank you! Sure, I'll make the changes.

@vercel vercel bot temporarily deployed to Preview October 8, 2022 19:58 Inactive
@eduardconstantin @danielschuster-muc
Change wizard placeholder name to character
8113c62 
Co-authored-by: Daniel Schuster <90754725+danielschuster-muc@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview October 9, 2022 07:08 Inactive
danielschuster-muc
danielschuster-muc requested changes Oct 9, 2022
View reviewed changes
Copy link
Owner

@danielschuster-muc danielschuster-muc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably also rename the missing_wizard.svg file to missing_character.svg.

@eduardconstantin
Copy link
Contributor Author

eduardconstantin commented Oct 9, 2022 •
edited

oh, in the folder, right

@vercel vercel bot temporarily deployed to Preview October 9, 2022 09:01 Inactive
danielschuster-muc
danielschuster-muc approved these changes Oct 9, 2022
View reviewed changes
Copy link
Owner

@danielschuster-muc danielschuster-muc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything‘s good now! Thank you for your contribution and those awesome images!

@eduardconstantin
Copy link
Contributor Author

You're welcome! Glad I could help!

@danielschuster-muc danielschuster-muc merged commit 67cf44c into danielschuster-muc:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielschuster-muc danielschuster-muc danielschuster-muc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Create new placeholder svg images
2 participants
@eduardconstantin @danielschuster-muc