Skip to content

Commit

Permalink
fix(mobile-messaging): fix event (un)register and saveUser (#4569)
Browse files Browse the repository at this point in the history
Fix methods for registering and unregistering events and improve comments. Also make return type for saveUser more descriptive.
  • Loading branch information
zbrckovic committed Jul 11, 2023
1 parent 0527afe commit fbd523f
Showing 1 changed file with 15 additions and 9 deletions.
24 changes: 15 additions & 9 deletions src/@awesome-cordova-plugins/plugins/mobile-messaging/index.ts
Expand Up @@ -328,16 +328,19 @@ export class MobileMessaging extends AwesomeCordovaNativePlugin {
* @param event
*/
@Cordova({
observable: true,
sync: true,
})
register(event: Event): Observable<Message> {
register(event: Event, handler: Function): void {
return;
}

/**
* Alias for `register`.
*/
@Cordova({
observable: true,
sync: true,
})
on(event: Event): Observable<Message> {
on(event: Event, handler: Function): void {
return;
}

Expand All @@ -350,16 +353,19 @@ export class MobileMessaging extends AwesomeCordovaNativePlugin {
* @param {Function} handler will be unregistered from event
*/
@Cordova({
observable: true,
sync: true,
})
unregister(event: Event): Observable<Message> {
unregister(event: Event, handler: Function): void {
return;
}

/**
* Alias for `unregister`.
*/
@Cordova({
observable: true,
sync: true,
})
off(event: Event): Observable<Message> {
off(event: Event, handler: Function): void {
return;
}

Expand Down Expand Up @@ -419,7 +425,7 @@ export class MobileMessaging extends AwesomeCordovaNativePlugin {
* @param {Object} userData. An object containing user data
*/
@Cordova()
saveUser(userData: UserData): Promise<any> {
saveUser(userData: UserData): Promise<UserData> {
return;
}

Expand Down

0 comments on commit fbd523f

Please sign in to comment.