Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(urbanairship): new functions for version cordova-urbanairship 14.0 #4097

Merged
merged 4 commits into from
Apr 2, 2022

Conversation

chvonrohr
Copy link
Contributor

I updated the existing plugin to implement all functions for the latest release.
Thereby, I added some @deprecated and @since jsdocs to show when they were added/removed

But, I am still not yet sure, what the successIndex and errorIndex are good for.

For example, this is the code of the code of awesome-cordova-plugins/urbanairship and works:

 /**
   * @param {function(namedUser)} success The function to call on success.
   * @param {string} success.namedUser The named user ID as a string.
   * @param {function(message)} [failure] Failure callback.
   * @param {string} failure.message The error message.
   */
  @Cordova()
  getNamedUser(): Promise<string> {
    return;
  }

whereas the original function of the cordova plugin looks the following:

getNamedUser: function(success, failure) { // ...

so shouldn't the successIndex be set to 0 here and why does it work without?

@danielsogl danielsogl changed the title Urban-Airship: new functions for version cordova-urbanairship 14.0 feat(urbanairship): new functions for version cordova-urbanairship 14.0 Apr 2, 2022
@danielsogl danielsogl merged commit 12ef7ac into danielsogl:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants