add network plugin for issue #89

[keithdmoore]

add cordova-network-information plugin

[keithdmoore]

@mlynch @tlancina I thought I had committer access to this repo. Maybe I only have committer access to the ngCordova repo. Would you or Tim mind giving me committer access to ionic-native?

[ihadeed]

Thanks for the PR @keithdmoore

1. No need to import the Connection interface into index.ts
2. The plugin hasn't been added yet. I'm working on it in the add-network-info branch here: https://github.com/driftyco/ionic-native/blob/add-network-info/src/plugins/networkinformation.ts

[mlynch]

@keithdmoore done!

[ihadeed]

Never mind my previous comment. Just saw your recent commit @keithdmoore

[keithdmoore]

@mlynch Thanks!
@ihadeed Sorry, I must have missed the fact that there was already an issue opened for this. I implemented it fully. Unless you disagree with my implementation, can we pull it in?

[ihadeed]

@keithdmoore

Shouldn't static get connection() be static get type() to match the original plugin?

[keithdmoore]

@ihadeed I can change that if you want. I went back and forth on that. I did deviate a little with the event handlers. onConnect and onDisconnect seemed to make more sense to me. onOnline and onOffline sound and look weird.

[ihadeed]

@keithdmoore Yeah onOnline does sound weird.

The reason I said change it to type because AFAIK the @CordovaProperty overrides the return value you have there by using the property name.
Reference: https://github.com/driftyco/ionic-native/blob/master/src/plugins/plugin.ts#L240-L259

[keithdmoore]

@ihadeed I am having trouble getting type to work. Were you able to get type to work? My committed code works with the usage examples in an app I am working on.

[ihadeed]

@keithdmoore Ahh. type could be a reserved word.

If the code you wrote works then I think that's fine. I just thought the @CordovaProperty would overwrite it. I guess it's just there to check if the plugin and Cordova exist.

[keithdmoore]

@ihadeed Fair enough. I just realized I left a comment that should be removed. Ugggg.

[ihadeed]

@keithdmoore this one ed14d87 ?

[keithdmoore]

@mlynch Looks like you gave the ngCordova team (which I am on) read access to ionic-native. Can we get admin access?

[ihadeed]

@keithdmoore @mlynch your input is appreciated here #86