Issue 134 #135
Closed
Issue 134 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @danielstjules |
|
mcrypt? |
|
mbstring? |
| @@ -39,5 +39,5 @@ before_script: | |||
| - if [[ $polyfill = 'false' ]]; then travis_retry composer remove symfony/polyfill-mbstring; fi | |||
|
|
|||
| script: | |||
| - vendor/bin/phpunit | |||
| - vendor/bin/phpunit --verbose | |||
There was a problem hiding this comment.
better to set this in the phpunit config
|
@GrahamCampbell - it's a WIP |
As is mbstring. Anyway, I'm not worried about it for now, see #134 (comment) My bigger concern is either updating the polyfill or getting rid of it. |
At some point, I feel polyfill support should be removed |
|
Closing for now - don't worry about it :) Travis doesn't support disabling extensions, and it's not worth compiling our own PHP from scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP on #134
All tests pass : https://travis-ci.org/danielstjules/Stringy/builds/124494966
Might be worth to SSH into the TravisCI container, if possible