Real strings from StaticStringy #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeyshockov
force-pushed
the
real-strings-from-static
branch
from
d0bddf8
to
6c95339
Compare
|
Sounds good! Breaks BC with the existing API, so will have to go into a new major release. |
|
Great! To be honest, it doesn't break documented API... Because all phpDoc comments about return types say that But it breaks real API of course :) |
|
You need to update the phpdoc. |
|
@GrahamCampbell, which one? Existing phpDoc comments already state that |
|
Existing PHPDocs are wrong, and reflect the API pre-2.x. Not sure when this regression was introduced. It could be marked a bug, but I'd rather play it safe. Current PR is fine, thanks! :) |
|
Merged into the 3.x dev branch #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that it's good to produce real strings from
StaticStringy, notStringyobject that can be casted to a string.Example situation: I do some manipulation with a string with
StaticStringy, then assign the result tobase_urioption of Guzzle client. After that I get "URI must be a string or UriInterface" error.With PHP 7 it's even more important, because of scalar type hinting.