Improve JSX support

Some JSX node types are hardcoded in childKeys to ensure correct property traversal
order. For example, this ensures that a JSXElement's children is traversed prior
to the closing element.

lib/nodeUtils.js

@@ -2,8 +2,15 @@ var stable = require('stable');
 
 /**
  * Cache for getChildren, holding the keys to traverse for a given Node type.
+ * Some JSX node types are hardcoded to ensure correct property traversal order.
+ * For example, this ensures that a JSXElement's children is traversed prior
+ * to the closing element.
  */
-var childKeys = {};
+var childKeys = {
+  JSXElement: ['openingElement', 'extra', 'children', 'closingElement'],
+  JSXOpeningElement: ['name', 'attributes'],
+  JSXAttribute: ['name', 'value'],
+};
 
 class NodeUtils {
   /**
@@ -93,7 +100,7 @@ class NodeUtils {
 
     if (!childKeys[node.type]) {
       childKeys[node.type] = Object.keys(node).filter((key) => {
-        return typeof node[key] === 'object';
+        return key !== 'loc' && typeof node[key] === 'object';
       });
     }
 
@@ -239,9 +246,12 @@ class NodeUtils {
    * @returns {boolean}
    */
   static literalsMatch(nodes) {
+    var isLiteral = (node) => {
+      return node.type.includes('Literal') || node.type === 'JSXText';
+    }
+
     return nodes[0] && nodes.every(node => {
-      return node && (!node.type.includes('Literal') ||
-        node.value === nodes[0].value);
+      return node && (!isLiteral(node) || node.value === nodes[0].value);
     });
   }
 }

spec/nodeUtilsSpec.js

@@ -234,6 +234,15 @@ describe('NodeUtils', function() {
       expect(res).to.be(false);
     });
 
+    it('treats JSXText as a literal', function() {
+      var res = NodeUtils.literalsMatch([
+        {type: 'JSXText', value: 'a'},
+        {type: 'JSXText', value: 'a'},
+        {type: 'JSXText', value: 'b'}
+      ]);
+      expect(res).to.be(false);
+    });
+
     it('ignores the values of nodes which are not literals', function() {
       var res = NodeUtils.literalsMatch([
         {type: 'Foo', value: 'a'},