Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt support? #3

Closed
stefanjudis opened this issue Oct 19, 2014 · 5 comments
Closed

Grunt support? #3

stefanjudis opened this issue Oct 19, 2014 · 5 comments

Comments

@stefanjudis
Copy link

Do you have plans on that?
And if not, do you mind when I wrap it? :bowtie:

@danielstjules
Copy link
Owner

Feel free! :) That would be helpful and really awesome, since I've been falling a bit behind on things. I'll hopefully get around to updating the bin itself to accept an ignore option (as per #2). But that's the only expected change to the bin coming up. Rest of it will be to lib/specs, which wouldn't affect the public API.

@stefanjudis
Copy link
Author

No problem. Will have a look into it now, should be done in the next couple of days. :bowtie:

https://github.com/stefanjudis/grunt-jsinspect

@alexeyraspopov
Copy link
Contributor

Great!

Also, I'm working on gulp-plugin for jsinspect and I hope I can ask some questions here. @danielstjules can you describe how diff and colors params work? Should they be configurable?

@danielstjules
Copy link
Owner

@alexeyraspopov Happy to hear you're interested in helping out!

  -D, --no-diff             disable 2-way diffs
  -C, --no-color            disable colors

I'd originally imagined that they'd both be on by default, but could be disabled. They're both simply booleans based on the provided flags, with color being passed once, and diff twice. Once for the inspector, telling it to generate diffs, a second time to the reporters, to have them use the diffs.

inspector = new Inspector(paths, {
  threshold:   program.threshold,
  diff:        program.diff,
  identifiers: program.identifiers
});

reporterType = reporters[program.reporter] || reporters.default;
new reporterType(inspector, program.diff);
inspector.run();

@danielstjules
Copy link
Owner

@alexeyraspopov @stefanjudis Feel free to ping me on here or twitter when done your individual plugins, and I'll link to them in the readme. :) I'm gonna close this in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants