Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about checking expectations in hooks #8

Merged

Conversation

ciarand
Copy link
Contributor

@ciarand ciarand commented Feb 2, 2014

This is the documentation adjustment discussed in #7.

This is the documentation adjustment discussed in danielstjules#7.
@danielstjules
Copy link
Owner

I hope I don't sound like a pedant by asking this, but what do you think of making it a smaller example (and using $this rather than the use construct) at the end of the readme under the heading "Notes", or something similar? I'm thinking I'd rather keep the introduction short, and not too full of extra details and highlights of potential issues. Do you agree that those concerns could be left towards the end - for people who are interested in using the lib?

@ciarand
Copy link
Contributor Author

ciarand commented Feb 4, 2014

Not at all. I do think that since they relate primarily to mocking frameworks they should be close to that section - how's this?

danielstjules added a commit that referenced this pull request Feb 4, 2014
Add a note about checking expectations in hooks
@danielstjules danielstjules merged commit 8a6c0ab into danielstjules:master Feb 4, 2014
@danielstjules
Copy link
Owner

Good idea, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants