Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default exception factory takes account of CustomExceptionFactory for ArgumentNullException only #157

Closed
DennisInSky opened this issue Jul 1, 2021 · 1 comment · Fixed by #158 or #160
Milestone

Comments

@DennisInSky
Copy link

Default implementation of IExceptionFactory does not take account of CustomeExceptionFactory in ArgumentException and ArgumentOutOfRangeException methods. Also, it both custom exception factory and custom exception message are defined, the latter is not propagated down to the custom exception factory and default one is used instead.

danielwertheim added a commit that referenced this issue Jul 6, 2021
Resulted in move of interface (which was wrongly placed from the beginning)
@danielwertheim
Copy link
Owner

@DennisInSky thanks for reporting. There's a preview release out with a fix for this: https://www.nuget.org/packages/Ensure.That/11.0.0-p1

Awaiting decision of potentially dropping .NET 4.5.1 support before making 11.0.0 final tracked in #159

@danielwertheim danielwertheim added this to the v11 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants