Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CIRBE #426

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Add support for CIRBE #426

merged 1 commit into from
Dec 7, 2022

Conversation

spsvihla
Copy link
Contributor

@spsvihla spsvihla commented Dec 5, 2022

Add python/telemetry/cirbe_70cm.py and python/telemetry/cirbe_bct_soh.py
Add python/satyaml/CIRBE.yml
Edit python/telemetry/CMakeLists.txt and python/telemetry/init.py

Signed-off-by: Sean Svihla Sean.Svihla@lasp.colorado.edu

Copy link
Owner

@daniestevez daniestevez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this!

I've made a couple of very minor comments regarding code style, but other than these, I think this is good and can be merged as soon as the comments are addressed.

python/telemetry/cirbe_70cm.py Outdated Show resolved Hide resolved
python/telemetry/cirbe_70cm.py Outdated Show resolved Hide resolved
Signed-off-by: Sean Svihla <Sean.Svihla@lasp.colorado.edu>
@spsvihla
Copy link
Contributor Author

spsvihla commented Dec 7, 2022

@daniestevez These changes have been added

Copy link
Owner

@daniestevez daniestevez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks! Merging.

@daniestevez daniestevez merged commit aa9c662 into daniestevez:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants