Added the mjml-msobutton component into the Docker image #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-pobeditel-2004
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Am I right that this docker image is based on this repository?
If so, may I ask you to accept proposed changes to add mjml-msobutton community component into the server image?
Previously I proposed several fixes to this component and they have been merged by original author - now this component reliably creates buttons that will be displayed correctly in MS Outlook. I thoroughly tested it and fixed everything that worked badly.
This change is fully backwards compatible - it just adds possibility to use
<mj-msobutton>tag that acts as usual<mj-button>tag but generates more code to provide button compatibility.